On Mon, Aug 05, 2013 at 01:37:18PM +0200, Kostya Shishkov wrote:
> On Mon, Aug 05, 2013 at 01:03:49PM +0200, Diego Biurrun wrote:
> > On Mon, Aug 05, 2013 at 12:55:30PM +0200, Diego Biurrun wrote:
> > > --- a/configure
> > > +++ b/configure
> > > @@ -1601,6 +1601,7 @@ lagarith_decoder_select="dsputil"
> > >  loco_decoder_select="golomb"
> > >  mdec_decoder_select="dsputil error_resilience mpegvideo"
> > > +metasound_decoder_select="lsp mdct sinewin"
> > >  mimic_decoder_select="dsputil hpeldsp"
> > >  mjpeg_decoder_select="dsputil hpeldsp"
> > > --- a/libavcodec/Makefile
> > > +++ b/libavcodec/Makefile
> > > @@ -378,6 +378,8 @@ OBJS-$(CONFIG_VORBIS_DECODER)          += vorbisdec.o 
> > > vorbisdsp.o vorbis.o \
> > >                                            vorbis_data.o xiph.o
> > >  OBJS-$(CONFIG_VORBIS_ENCODER)          += vorbisenc.o vorbis.o \
> > >                                            vorbis_data.o
> > > +OBJS-$(CONFIG_VOXWARE_DECODER)         += metasound.o metasound_data.o \
> > > +                                          twinvq.o
> > >                                            vp56rac.o
> > > --- a/libavcodec/allcodecs.c
> > > +++ b/libavcodec/allcodecs.c
> > > @@ -324,6 +324,7 @@ void avcodec_register_all(void)
> > >      REGISTER_DECODER(VMDAUDIO,          vmdaudio);
> > >      REGISTER_ENCDEC (VORBIS,            vorbis);
> > > +    REGISTER_DECODER(VOXWARE,           voxware);
> > >      REGISTER_DECODER(WAVPACK,           wavpack);
> > >      REGISTER_DECODER(WMALOSSLESS,       wmalossless);
> > 
> > Please be consistent with the naming and either call this thing voxware
> > or metasound, but not a mixture of both in different places.
> 
> VoxWare is the name of the company, it has several codecs, e.g. MetaSound,
> MetaVoice, RT29, etc. But somebody ignored all that and added CODEC_ID_VOXWARE
> instead for this codec (and TWOCC entry). I'd like to use something more
> precise but I have to use stuff that's already here.

So let's change it and make those twocc and codec_id values more precise...

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to