On 18/08/13 16:19, Martin Storsjö wrote: > This looks good. What about adding an else case that returns an > error for all other unknown/unhandled AVMEDIA types? Or alternatively > just set the timescale based on time_base for them as well?
AVMEDIA_TYPE_ATTACHMENT rightfully does not have a timebase. AVMEDIA_TYPE_UNKNOWN is purely opaque so could have one. > If we do either of these, patch 2/3 shouldn't be necessary, right? > (Otherwise if we go for doing the check as in 2/3, we might need to > add a number of other checks around the muxer as well.) I do not have enough experience about mov and this set is made to cope with a crash mostly, I'll ask you on irc for mov specification so I can see how wrong I am regarding my assumptions on timecode. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
