On Fri, Aug 16, 2013 at 05:39:05PM -0700, Guillaume Martres wrote: > Only require -strict experimental if libvpx was built with > --enable-experimental .
Isn't "-strict experimental" only needed to encode VP9? Then you should say so. > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -599,10 +599,10 @@ OBJS-$(CONFIG_LIBVO_AACENC_ENCODER) += > libvo-aacenc.o mpeg4audio.o > OBJS-$(CONFIG_LIBVO_AMRWBENC_ENCODER) += libvo-amrwbenc.o > OBJS-$(CONFIG_LIBVORBIS_ENCODER) += libvorbis.o \ > vorbis_data.o vorbis_parser.o > -OBJS-$(CONFIG_LIBVPX_VP8_DECODER) += libvpxdec.o > -OBJS-$(CONFIG_LIBVPX_VP8_ENCODER) += libvpxenc.o > -OBJS-$(CONFIG_LIBVPX_VP9_DECODER) += libvpxdec.o > -OBJS-$(CONFIG_LIBVPX_VP9_ENCODER) += libvpxenc.o > +OBJS-$(CONFIG_LIBVPX_VP8_DECODER) += libvpxdec.o libvpx_common.o > +OBJS-$(CONFIG_LIBVPX_VP8_ENCODER) += libvpxenc.o libvpx_common.o > +OBJS-$(CONFIG_LIBVPX_VP9_DECODER) += libvpxdec.o libvpx_common.o > +OBJS-$(CONFIG_LIBVPX_VP9_ENCODER) += libvpxenc.o libvpx_common.o Just libvpx.c is better; we commonly name shared code like that. > --- /dev/null > +++ b/libavcodec/libvpx_common.c > @@ -0,0 +1,53 @@ > +/* > + * Copyright (c) 2013, Google, Inc. > + * > + * This file is part of Libav. Did you do this while employed or contracted by Google? > +#include <string.h> > + > +#include <vpx/vpx_codec.h> > + > +#include "avcodec.h" > +#include "libvpx_common.h" nit: Drop the first empty line > --- /dev/null > +++ b/libavcodec/libvpx_common.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (c) 2013, Google, Inc. > + * > + * This file is part of Libav. See above; not that the contents of this header is copyrightable .. > + * You should have received a copy of the GNU Lesser General Public > + * License along with Libav; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 > USA > + */ > + > +int ff_vpx_check_experimental(AVCodecContext *avctx); This is missing multiple inclusion guards and will not compile standalone. Please use "make check" as suggested by the developer docs. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
