On 19/08/13 20:49, John Stebbins wrote:
> QuickTime requires that the stsd.text box be completely filled in.
> ---
>  libavformat/movenc.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index e7b2feb..9a7a69d 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -2992,12 +2992,17 @@ static void mov_create_chapter_track(AVFormatContext 
> *s, int tracknum)
>      MOVTrack *track = &mov->tracks[tracknum];
>      AVPacket pkt = { .stream_index = tracknum, .flags = AV_PKT_FLAG_KEY };
>      int i, len;
> +    // These properties are required to make QT recognize the chapter track
> +    uint8_t chapter_properties[43] = { 0, 0, 0, 0, 0, 0, 0, 1, };
>  
>      track->mode = mov->mode;
>      track->tag = MKTAG('t','e','x','t');
>      track->timescale = MOV_TIMESCALE;
>      track->enc = avcodec_alloc_context3(NULL);
>      track->enc->codec_type = AVMEDIA_TYPE_SUBTITLE;
> +    track->enc->extradata = av_malloc(sizeof(chapter_properties));

memory allocations can fail, pleas manage the case.

> +    track->enc->extradata_size = sizeof(chapter_properties);
> +    memcpy(track->enc->extradata, chapter_properties, 
> sizeof(chapter_properties));
>  
>      for (i = 0; i < s->nb_chapters; i++) {
>          AVChapter *c = s->chapters[i];
> @@ -3453,8 +3458,10 @@ static int mov_write_trailer(AVFormatContext *s)
>          mov_write_mfra_tag(pb, mov);
>      }
>  
> -    if (mov->chapter_track)
> +    if (mov->chapter_track) {
> +        av_free(mov->tracks[mov->chapter_track].enc->extradata);
>          av_freep(&mov->tracks[mov->chapter_track].enc);
> +    }
>  
>      for (i = 0; i < mov->nb_streams; i++) {
>          if (mov->tracks[i].tag == MKTAG('r','t','p',' '))
> 

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to