On Tue, 20 Aug 2013, John Stebbins wrote:

On 08/20/2013 07:09 AM, Martin Storsjö wrote:
On Mon, 19 Aug 2013, John Stebbins wrote:

From: Clément Bœsch <[email protected]>

Faststart moves moov atom to beginning of file and rewrites the reset of
the file after muxing is complete.
---
libavformat/movenc.c | 139 +++++++++++++++++++++++++++++++++++++++++++++++++--
libavformat/movenc.h |   3 ++
2 files changed, 138 insertions(+), 4 deletions(-)
This still is missing a check for the custom io flag. Sure, you probably
won't try to enable this flag in that setup, but I'd like to have that
clearly pointed out.



It's there... it disables faststart if custom io is set.

+        if ((mov->flags & FF_MOV_FLAG_FRAGMENT) ||
+            (s->flags & AVFMT_FLAG_CUSTOM_IO))
+            mov->flags &= ~FF_MOV_FLAG_FASTSTART;

Oh, sorry, I missed that. The patch is ok with me then - I'll probably push it tomorrow if there's no other objections from e.g. Luca.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to