On 02/09/13 11:23, Christian Schmidt wrote:
> Submit a correct pointer to av_free() on shutdown.

Would be better split it up. it is just a small improvement.

> The sample buffering logic does not take into account that the blocksize
> could change. Reset the buffer if the channel configuration  changes,
> since if there are leftover samples, it is most likely a broken or
> misconcatenated stream. This could lead to negative numbers for
> missing_samples during decoding.

That one seems more serious, are you sure resetting that field is all
you need?

Leftover samples might be flushed before providing the actual data, but
could be done maybe in a later patch if you are busy.

lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to