On Tue, Sep 03, 2013 at 12:17:17PM +0200, Alexandra Khirnova wrote:
> --- a/libavformat/gxfenc.c
> +++ b/libavformat/gxfenc.c
> @@ -872,12 +873,13 @@ static int gxf_write_packet(AVFormatContext *s,
> AVPacket *pkt)
> if (!(gxf->flt_entries_nb % 500)) {
> - gxf->flt_entries = av_realloc(gxf->flt_entries,
> -
> (gxf->flt_entries_nb+500)*sizeof(*gxf->flt_entries));
> - if (!gxf->flt_entries) {
> + if ((err = av_reallocp_array(&gxf->flt_entries,
> (gxf->flt_entries_nb + 500),
Still has pointless () ...
> --- a/libavformat/matroskaenc.c
> +++ b/libavformat/matroskaenc.c
> @@ -294,14 +294,17 @@ static mkv_seekhead * mkv_start_seekhead(AVIOContext
> *pb, int64_t segment_offset
>
> - entries = av_realloc(entries, (seekhead->num_entries + 1) *
> sizeof(mkv_seekhead_entry));
> - if (entries == NULL)
> - return AVERROR(ENOMEM);
> + if ((err = av_reallocp_array(&entries, seekhead->num_entries + 1,
> + sizeof(mkv_seekhead_entry))) < 0) {
Still uses sizeof(type) instead of sizeof(*pointer) ...
Please don't just fix up the two examples I pointed out in my review,
but review the rest of the patch yourself for the same kind of issue.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
