On 09/05/2013 01:25 AM, Hendrik Leppkes wrote: > On Wed, Sep 4, 2013 at 10:08 PM, John Stebbins <[email protected]>wrote: > >> A change in framesize caused a perpetual loss of synchronization. >> So read (and use) the frame size from the frame header instead of >> setting it only once. >> > Won't this patch still trip up on the first frame with the size change > (assuming the new size is smaller), because the new size is only parsed > once it found the frame end? > It would be ideal if there are no hicups at all during playback. > > Yes, it will trip over a frame or two when the frame size changes to a smaller size. I acknowledged this in the original thread for this patch.
From that email, "Ideally, parsing the header should happen before dca_find_frame_end(). But that would require quite a lot more rearrangement of code, and what I have done works sufficiently well. It will result in the loss of a frame or two if there is a transition from a larger frame size to a smaller frame size." If you would like to do the larger rearrangement of code to accomplish a skip free transition, I don't mind working on that. But my time is limited and it may be a week or two before I could create a new patch. This patch is a step in the right direction, so we could push this patch and submit the other as a follow up later. -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
signature.asc
Description: OpenPGP digital signature
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
