On Fri, Sep 13, 2013 at 04:30:59PM -0400, Justin Ruggles wrote:
> ---
>  doc/general.texi        |   2 +
>  libavcodec/Makefile     |   1 +
>  libavcodec/allcodecs.c  |   1 +
>  libavcodec/avcodec.h    |   1 +
>  libavcodec/codec_desc.c |   8 ++
>  libavcodec/vp8.c        |  18 ++--
>  libavcodec/vp8.h        |   7 ++
>  libavcodec/webp.c       | 246 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  libavformat/img2.c      |   1 +
>  9 files changed, 276 insertions(+), 9 deletions(-)
>  create mode 100644 libavcodec/webp.c

See the new codec checklist.

> --- /dev/null
> +++ b/libavcodec/webp.c
> @@ -0,0 +1,246 @@
> +
> +    s->width  = 0;
> +    s->height = 0;
> +    *got_frame = 0;
> +    s->has_alpha = 0;

nit: Align the s-> expressions.

> +            pre_p       = (alpha_header >> 4) & 0x03;
> +            filter_m    = (alpha_header >> 2) & 0x03;
> +            compression =  alpha_header       & 0x03;

nit: pointless ()

> +            if (filter_m || compression) {
> +                av_log(avctx, AV_LOG_VERBOSE,
> +                       "skipping unsupported ALPHA chunk\n");
> +            } else {
> +                s->has_alpha = 1;
> +            }

nit: pointless {}

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to