On Sun, 8 Sep 2013 14:18:06 -0700, John Stebbins <[email protected]> wrote: > On 09/08/2013 01:28 PM, Vittorio Giovara wrote: > > On Saturday, September 7, 2013, John Stebbins wrote: > > > >> This can be optionally disabled whith the "showall" flags2 option. > >> When in "showall" mode, incomplete frames are signalled through > >> AVFrame.flags FRAME_FLAG_INCOMPLETE_FRAME. > > > > > > I think it'd be better to leave the current behavior as default and an > > option like WAIT_KEYFRAME that implements your idea. > > Also does this apply to h264 or does this work with other codecs too? In > > the former case then a private decode option would be a better place than > > flags2 for this flag. > > > > The option currently only applies to h264, but it *could* be applied to other > codecs if desired. I can make it a private option if that's the group > consensus though.
IMO "show potentially broken frames" is a general enough concept so that it should be a global option. And the default should be to skip them. IIRC in hevc such frames are explicitly in the spec and a compliant decoder shouldn't output them. What I'm not sure about is the part with frame flags. It might be better to keep such information in AVCodecContext. Opinions? -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
