On 2013-09-17 12:13:49 +0300, Martin Storsjö wrote:
> On Mon, 16 Sep 2013, Diego Biurrun wrote:
>
> > On Mon, Sep 16, 2013 at 10:06:18PM +0300, Martin Storsjö wrote:
> >> --- a/libavcodec/rv34.c
> >> +++ b/libavcodec/rv34.c
> >> @@ -1495,8 +1495,10 @@ av_cold int ff_rv34_decode_init(AVCodecContext
> >> *avctx)
> >>
> >> - if ((ret = rv34_decoder_alloc(r)) < 0)
> >> + if ((ret = rv34_decoder_alloc(r)) < 0) {
> >> + ff_MPV_common_end(&r->s);
> >> return ret;
> >> + }
> >
> > Don't you have to do the same thing on line 1520?
>
> Possibly - I'm not sure how the error handling/cleanup is handled for the
> threading case off-hand (the sample I have doesn't get that far). Janne or
> Kostya?
Yes, it needs the same change. It's probably hard to hit in practice but
it would leak memory on the error path.
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
