I spent some time playing with include-what-you-use clang tool and found that
libav headers could benefit from removing a few unused headers.
So I propose a first set of patches that modify which headers are included and
in what order, specifically:
1. make sure there is a line between copyright header and the first include
2. include system headers first
3. include headers from the same library
4. include headers from other libav libraries
5. incldue headers from other libraries
6. any other ifdef library
7. make sure there ia a line between the last include or ifdef and the code
8. move any non-doxygen comment before the include, if applicable
I could only test this set on linux x86, so I would really appreciate help for
the other platforms (or instructions for this).
When there is agreement on the modifications on this set I'll move on the lavc,
lavfi, lavfo files and see if there is any other header that should be included.
Cheers,
Vittorio
Vittorio Giovara (4):
cmdutils: headers cleanup
avutil: headers cleanup
swscale: headers cleanup
avresample: headers cleanup
avconv.c | 32 ++++++++++++--------------------
avconv.h | 12 +++++-------
avconv_filter.c | 2 --
avconv_opt.c | 3 ++-
avplay.c | 30 ++++++++++++++++--------------
avprobe.c | 6 ++++--
avserver.c | 28 ++++++++++++++--------------
cmdutils.c | 15 ++++++++++-----
cmdutils.h | 3 +--
libavresample/audio_convert.c | 8 ++++----
libavresample/audio_convert.h | 4 +---
libavresample/audio_data.c | 3 ++-
libavresample/audio_data.h | 5 +++--
libavresample/audio_mix.c | 6 +++---
libavresample/audio_mix.h | 2 --
libavresample/audio_mix_matrix.c | 8 ++------
libavresample/avresample-test.c | 3 ++-
libavresample/avresample.h | 5 +++--
libavresample/dither.c | 7 ++++---
libavresample/internal.h | 3 ++-
libavresample/options.c | 7 ++++---
libavresample/resample.c | 6 +++---
libavresample/resample.h | 1 -
libavresample/utils.c | 13 ++++++-------
libavutil/adler32.h | 1 +
libavutil/audio_fifo.c | 1 -
libavutil/avassert.h | 1 +
libavutil/avstring.h | 1 +
libavutil/bswap.h | 3 ++-
libavutil/channel_layout.c | 1 -
libavutil/common.h | 2 +-
libavutil/cpu.c | 3 +++
libavutil/cpu.h | 5 +++--
libavutil/crc.h | 1 +
libavutil/des.c | 3 +--
libavutil/dict.c | 1 +
libavutil/error.c | 2 +-
libavutil/eval.c | 2 --
libavutil/fifo.c | 1 +
libavutil/fifo.h | 1 +
libavutil/file.c | 9 ++++++---
libavutil/file_open.c | 9 +++++----
libavutil/frame.c | 1 +
libavutil/frame.h | 4 +---
libavutil/imgutils.c | 2 +-
libavutil/imgutils.h | 1 +
libavutil/internal.h | 1 +
libavutil/intfloat.h | 1 +
libavutil/intfloat_readwrite.c | 1 +
libavutil/intfloat_readwrite.h | 1 +
libavutil/intreadwrite.h | 1 +
libavutil/lfg.c | 2 +-
libavutil/libm.h | 1 +
libavutil/log.c | 14 +++++++-------
libavutil/log.h | 2 +-
libavutil/lzo.c | 1 -
libavutil/md5.c | 1 +
libavutil/mem.c | 12 ++++++------
libavutil/mem.h | 2 +-
libavutil/opt.c | 2 --
libavutil/opt.h | 1 -
libavutil/parseutils.c | 1 -
libavutil/pixfmt.h | 2 +-
libavutil/random_seed.c | 14 ++++++++------
libavutil/random_seed.h | 1 +
libavutil/rational.c | 2 +-
libavutil/rational.h | 1 +
libavutil/rc4.c | 2 +-
libavutil/samplefmt.c | 7 +++----
libavutil/samplefmt.h | 1 -
libavutil/sha.c | 1 -
libavutil/time.c | 12 +++++++-----
libavutil/timer.h | 6 +++---
libavutil/utils.c | 2 +-
libavutil/x86/cpu.c | 2 --
libavutil/xtea.c | 1 +
libswscale/colorspace-test.c | 2 +-
libswscale/input.c | 11 +++--------
libswscale/options.c | 6 +++---
libswscale/output.c | 13 ++++---------
libswscale/rgb2rgb.c | 6 ++----
libswscale/rgb2rgb.h | 3 ++-
libswscale/swscale-test.c | 5 ++++-
libswscale/swscale.c | 12 ++++--------
libswscale/swscale.h | 3 ++-
libswscale/swscale_internal.h | 8 ++++----
libswscale/swscale_unscaled.c | 6 ++----
libswscale/utils.c | 34 +++++++++++++++++-----------------
libswscale/version.h | 6 ++++--
libswscale/x86/rgb2rgb.c | 1 -
libswscale/x86/swscale.c | 3 ---
libswscale/x86/yuv2rgb.c | 5 -----
libswscale/yuv2rgb.c | 7 ++-----
93 files changed, 241 insertions(+), 255 deletions(-)
--
1.7.9.5
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
