On 01/10/13 15:51, Vittorio Giovara wrote:
> From: Thilo Borgmann <[email protected]>
>
> ---
> This would require adding a few samples to FATE.
> Double checking for this test is welcome ^^
>
> Vittorio
>
> tests/Makefile | 1 +
> tests/fate-run.sh | 4 +
> tests/fate/exif.mak | 14 ++
> tests/ref/fate/exif-image-embedded | 359
> ++++++++++++++++++++++++++++++++++++
> tests/ref/fate/exif-image-jpg | 66 +++++++
> tests/ref/fate/exif-image-tiff | 25 +++
> 6 files changed, 469 insertions(+)
> create mode 100644 tests/fate/exif.mak
> create mode 100644 tests/ref/fate/exif-image-embedded
> create mode 100644 tests/ref/fate/exif-image-jpg
> create mode 100644 tests/ref/fate/exif-image-tiff
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 132a1a7..0d22b32 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -72,6 +72,7 @@ include $(SRC_PATH)/tests/fate/demux.mak
> include $(SRC_PATH)/tests/fate/dfa.mak
> include $(SRC_PATH)/tests/fate/dpcm.mak
> include $(SRC_PATH)/tests/fate/ea.mak
> +include $(SRC_PATH)/tests/fate/exif.mak
> include $(SRC_PATH)/tests/fate/filter-audio.mak
> include $(SRC_PATH)/tests/fate/filter-video.mak
> include $(SRC_PATH)/tests/fate/flac.mak
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index b6c7384..903c95d 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -75,6 +75,10 @@ probefmt(){
> run avprobe -show_format_entry format_name -v 0 "$@"
> }
>
> +probeframes(){
> + run avprobe -show_frames -v 0 "$@"
> +}
Remind me to make fate-run.sh a fate-run.d we have too many applets.
You would need to implement show_frames btw.
> avconv(){
> dec_opts="-threads $threads -thread_type $thread_type"
> avconv_args="-nostats -cpuflags $cpuflags"
> diff --git a/tests/fate/exif.mak b/tests/fate/exif.mak
> new file mode 100644
> index 0000000..3953b62
> --- /dev/null
> +++ b/tests/fate/exif.mak
<diego>Alphabetical order might be nice</diego>
> @@ -0,0 +1,14 @@
> +# test exif metadata in TIFF images
> +FATE_SAMPLES_EXIF-$(call DEMDEC, IMAGE2, TIFF) += fate-exif-image-tiff
> +fate-exif-image-tiff: CMD = probeframes
> $(TARGET_SAMPLES)/exif/image_small.tiff
> +
> +# test exif metadata in JPG images
> +FATE_SAMPLES_EXIF-$(call DEMDEC, IMAGE2, MJPEG) += fate-exif-image-jpg
> +fate-exif-image-jpg: CMD = probeframes $(TARGET_SAMPLES)/exif/image_small.jpg
> +
> +# test exif metadata in MP3 with embedded JPEG images
> +FATE_SAMPLES_EXIF-$(call ALLYES, MP3_DEMUXER IMAGE2_DEMUXER MJPEG_DECODER)
> += fate-exif-image-embedded
> +fate-exif-image-embedded: CMD = probeframes
> $(TARGET_SAMPLES)/exif/embedded_small.mp3
> +
> +# add all -yes targets to the tested targets
> +FATE_SAMPLES_FFMPEG += $(FATE_SAMPLES_EXIF-yes)
adding a fate-exif shorthand would be nice, exif can be embedded on videos?
> diff --git a/tests/ref/fate/exif-image-embedded
> b/tests/ref/fate/exif-image-embedded
> new file mode 100644
> index 0000000..39755a1
> --- /dev/null
The references are bogus, by default we should use the ini markup now.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
