On Wed, Oct 02, 2013 at 05:34:45PM +0200, Luca Barbato wrote:
> --- a/libavutil/log.h
> +++ b/libavutil/log.h
> @@ -89,8 +89,19 @@ typedef struct AVClass {
> 
> +/**
> + * No output.
> + */
>  #define AV_LOG_QUIET    -8
> 
>  /**
> @@ -117,7 +128,14 @@ typedef struct AVClass {
>   */
>  #define AV_LOG_WARNING  24
> 
> +/**
> + * Standard information
> + */
>  #define AV_LOG_INFO     32
> +
> +/**
> + * Detailed information.
> + */
>  #define AV_LOG_VERBOSE  40

Be consistent with periods; I'd drop them.

> @@ -126,26 +144,90 @@ typedef struct AVClass {
> +
> +/**
> + * Get the current log level

.

> +/**
> + * Set the log level

.

> +/**
> + * Set the logging callback

.
> + *
> + * @see av_log_default_callback

I prefer an empty line between the brief description and @see
like you do here.

> + * @param callback A logging function with a signature compatible.

compatible signature

> +/**
> + * Default logging callback
> + *
> + * It prints to stderr the message, optionally colorizing them.

Please stick to subject then object order in English, i.e. "the message
to stderr".  Try to remember this, it's a recurring mistake.

colorizing it

> +/**
> + * Return the context name

.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to