On 10/03/2013 06:13 PM, Justin Ruggles wrote:
On 10/01/2013 01:44 PM, Diego Biurrun wrote:
This avoids building mmxext and sse2 code when disabled by configure.
---
libavcodec/x86/fdct.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavcodec/x86/fdct.c b/libavcodec/x86/fdct.c
index bd76648..6d595aa 100644
--- a/libavcodec/x86/fdct.c
+++ b/libavcodec/x86/fdct.c
@@ -34,7 +34,7 @@
#include "libavutil/x86/asm.h"
#include "libavcodec/dct.h"
-#if HAVE_INLINE_ASM
+#if HAVE_MMX_INLINE
//////////////////////////////////////////////////////////////////////
//
@@ -556,6 +556,10 @@ void ff_fdct_mmx(int16_t *block)
}
}
+#endif /* HAVE_MMX_INLINE */
+
+#if HAVE_MMXEXT_INLINE
+
void ff_fdct_mmxext(int16_t *block)
{
DECLARE_ALIGNED(8, int64_t, align_tmp)[16];
@@ -574,6 +578,10 @@ void ff_fdct_mmxext(int16_t *block)
}
}
+#endif /* HAVE_MMXEXT_INLINE */
+
+#if HAVE_SSE2_INLINE
+
void ff_fdct_sse2(int16_t *block)
{
DECLARE_ALIGNED(16, int64_t, align_tmp)[16];
@@ -583,4 +591,4 @@ void ff_fdct_sse2(int16_t *block)
fdct_row_sse2(block1, block);
}
-#endif /* HAVE_INLINE_ASM */
+#endif /* HAVE_SSE2_INLINE */
Please check where these functions are used. I think those conditions
may need to also be changed to match.
Oh, nevermind. Didn't see the next patch. Please squash patches 3/8 and 4/8.
Thanks,
Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
