On Fri, Oct 04, 2013 at 01:01:16PM +0200, Anton Khirnov wrote: > On Wed, 2 Oct 2013 22:22:34 +0200, Diego Biurrun <[email protected]> wrote: > > On Wed, Oct 02, 2013 at 03:39:12PM +0200, Vittorio Giovara wrote: > > > --- a/libavformat/Makefile > > > +++ b/libavformat/Makefile > > > @@ -218,7 +218,8 @@ OBJS-$(CONFIG_OGG_DEMUXER) += oggdec.o > > > \ > > > oggparsespeex.o \ > > > oggparsetheora.o \ > > > oggparsevorbis.o \ > > > - vorbiscomment.o > > > + vorbiscomment.o \ > > > + flacdec_picture.o > > > > So why does Ogg depend on FLAC now? Something seems to be in > > need of different splitting or naming. > > The format in which the pictures are stored is the FLAC format. > > Xiph says: > The binary FLAC picture structure is base64 encoded and placed within a > VorbisComment with the tag name "METADATA_BLOCK_PICTURE". This is the > preferred > and recommended way of embedding cover art within VorbisComments. > > So that file is correctly named IMO
OK, now it starts making sense. I would suggest "flac_picture.c" as name. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
