On Mon, Oct 07, 2013 at 10:08:40PM +0200, Anton Khirnov wrote:
> --- /dev/null
> +++ b/tests/fate/libavresample.mak
> @@ -0,0 +1,21 @@
> +CROSS_TEST = $(foreach I,$(1),$(foreach J,$(1),$(if $(filter-out 
> $(I),$(J)),$(eval $(call $(2),$(I),$(J),$(3),$(4))),)))

Is the following more readable?

CROSS_TEST = $(foreach I,$(1),                                                  
\
                       $(foreach J,$(1),                                        
\
                                 $(if $(filter-out $(I),$(J)),                  
\
                                      $(eval $(call $(2),$(I),$(J),$(3),$(4))), 
\
                                      )))

> +$(eval $(call CROSS_TEST,$(MIX_CHANNELS),MIX,q8,s16p))
> +$(eval $(call CROSS_TEST,$(MIX_CHANNELS),MIX,q15,s16p))
> +$(eval $(call CROSS_TEST,$(MIX_CHANNELS),MIX,flt,fltp))

You already eval within CROSS_TEST, so you don't need to repeat it.

The same applies to 2/2.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to