On Wed, Oct 09, 2013 at 11:54:35AM +0300, Martin Storsjö wrote: > On Mon, 7 Oct 2013, Loren Merritt wrote: > >Module: libav > >Branch: master > >Commit: e52567c2954f627d420b30f75f71af2f2e4afe80 > > > >Author: Loren Merritt <[email protected]> > >Committer: Derek Buitenhuis <[email protected]> > >Date: Thu Sep 12 18:06:23 2013 +0000 > > > >build: Strip spurious labels > > > >The implementation of 25cb0c1a involves lots of spurious labels. > > > >The effect of keeping those labels around is making debugging harder. > >Those labels are meaningless, and complicate the disassembly. Also, > >gdb can't tell the difference between them and function entry points. > > > >This new strip command is irrelevant to any usage of Libav that would > >have used the old fully stripped version, because the old one was for > >non-debug use. > > > >Signed-off-by: Derek Buitenhuis <[email protected]> > > > >--- > > > >configure | 3 +++ > >library.mak | 1 + > >2 files changed, 4 insertions(+) > > > >diff --git a/configure b/configure > >index 2e2a151..167f4ee 100755 > >--- a/configure > >+++ b/configure > >@@ -1974,6 +1974,7 @@ nm_default="nm -g" > >objformat="elf" > >pkg_config_default=pkg-config > >ranlib="ranlib" > >+strip="strip" > >yasmexe="yasm" > > > >nogas=":" > >@@ -2232,6 +2233,7 @@ cc_default="${cross_prefix}${cc_default}" > >nm_default="${cross_prefix}${nm_default}" > >pkg_config_default="${cross_prefix}${pkg_config_default}" > >ranlib="${cross_prefix}${ranlib}" > >+strip="${cross_prefix}${strip}" > > > >sysinclude_default="${sysroot}/usr/include" > > > >@@ -4166,6 +4168,7 @@ AR=$ar > >ARFLAGS=$arflags > >AR_O=$ar_o > >RANLIB=$ranlib > >+STRIP=$strip > >LN_S=$ln_s > >CPPFLAGS=$CPPFLAGS > >CFLAGS=$CFLAGS > >diff --git a/library.mak b/library.mak > >index 88d33dc..58f6360 100644 > >--- a/library.mak > >+++ b/library.mak > >@@ -25,6 +25,7 @@ $(SUBDIR)%-test.i: $(SUBDIR)%.c > >$(SUBDIR)x86/%.o: $(SUBDIR)x86/%.asm > > $(DEPYASM) $(YASMFLAGS) -I $(<D)/ -M -o $@ $< > $(@:.o=.d) > > $(YASM) $(YASMFLAGS) -I $(<D)/ -o $@ $< > >+ -@ $(if $(STRIP), $(STRIP) -wN '..@*' $@) > > This gives warnings about -wN being unrecognized on OS X. (The build > still succeeds though.)
The patch has multiple other issues and was not OKed. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
