On 10/9/2013 12:04 PM, Diego Biurrun wrote: >>> $(SUBDIR)x86/%.o: $(SUBDIR)x86/%.asm >>> $(DEPYASM) $(YASMFLAGS) -I $(<D)/ -M -o $@ $< > $(@:.o=.d) >>> $(YASM) $(YASMFLAGS) -I $(<D)/ -o $@ $< >>> + -@ $(if $(STRIP), $(STRIP) -wN '..@*' $@) >> >> Not sure what you are trying to achieve with the if, $(STRIP) should >> always be set ... >> >> If we bring back stripping, we'll need the rest of the portability >> parts from e0be794 as well. > > These comments were never addressed.
I somehow missed them. It looks like this $(if , ) is left over from x264. It's a simple fix. CC'd Loren to confirm. I do not see anything we'd need for our use case from e0be794. Please comment on that. > I did not review this patch in much detail because the whole set was > still up in the air and this looks like it would require a lot of > work in order to become acceptable. I respectfully disagree[1]. Also, I had them OK'd by more than one other developer. It is not my problem if you want to complain about them being pushed after posting no comments on many for weeks. - Derek _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
