On Thu, 10 Oct 2013 21:14:36 +0200, Maxim Polijakowski <[email protected]> wrote: > Hi crews, > > the attached patch adds an open-source decoder for Sony's ATRAC3+ > format. There is a partial description of its internals located here: > http://wiki.multimedia.cx/index.php?title=ATRAC3plus > > Samples: http://samples.mplayerhq.hu/A-codecs/ATRAC3+/ > > Because the patch is huge, I expect several review rounds. > > Therefore, I would like to kindly ask you to sort your review comments > according to the following priority list: > --> functionality improvements (code refractions resulting in faster or > smaller code) > --> security improvements (code refractions resulting in more secure code) > --> cosmetic improvements (grammar, spelling etc.) > > Any help regarding fuzzy testing and pointing out insecure code would be > very appreciated! > > Thank you in advance! > Best regards > Maxim > From b29fed72addcbdf8043bd9e6d9f74c745edebabb Mon Sep 17 00:00:00 2001 > From: Maxim Poliakovski <[email protected]> > Date: Mon, 2 Sep 2013 12:31:58 +0200 > Subject: [PATCH 1/2] ATRAC3+ decoder > > Cleanup by Diego Biurrun. > --- > Changelog | 1 + > configure | 1 + > doc/general.texi | 1 + > libavcodec/Makefile | 3 + > libavcodec/allcodecs.c | 1 + > libavcodec/atrac3plus.c | 1735 +++++++++++++++++++++++++++++++++++++ > libavcodec/atrac3plus.h | 183 ++++ > libavcodec/atrac3plus_data.c | 1940 > ++++++++++++++++++++++++++++++++++++++++++ > libavcodec/atrac3plus_data.h | 144 ++++ > libavcodec/atrac3plusdec.c | 394 +++++++++ > libavcodec/atrac3plusdsp.c | 658 ++++++++++++++ > libavcodec/version.h | 2 +- > 12 files changed, 5062 insertions(+), 1 deletion(-) > create mode 100644 libavcodec/atrac3plus.c > create mode 100644 libavcodec/atrac3plus.h > create mode 100644 libavcodec/atrac3plus_data.c > create mode 100644 libavcodec/atrac3plus_data.h > create mode 100644 libavcodec/atrac3plusdec.c > create mode 100644 libavcodec/atrac3plusdsp.c > [...] > + > + *got_frame_ptr = 1; > + > + return avctx->block_align;
Returning block_align here seems a bit weird, when i don't see it used at all in any other place. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
