On Mon, Oct 14, 2013 at 03:17:35PM +0200, Luca Barbato wrote: > On 14/10/13 14:17, Vittorio Giovara wrote: > > On Mon, Oct 14, 2013 at 1:53 PM, Luca Barbato <[email protected]> wrote: > >> On 14/10/13 12:01, Diego Biurrun wrote: > >>> On Sun, Oct 13, 2013 at 03:22:09AM +0200, Luca Barbato wrote: > >>>> --- a/libavcodec/cavs.c > >>>> +++ b/libavcodec/cavs.c > >>>> @@ -376,84 +376,99 @@ void ff_cavs_modify_mb_i(AVSContext *h, int > >>>> *pred_mode_uv) > >>>> { > >>>> - const int mx= mv->x + src_x_offset*8; > >>>> - const int my= mv->y + src_y_offset*8; > >>>> + const int mx = mv->x + src_x_offset*8; > >>>> + const int my = mv->y + src_y_offset*8; > >>> > >>> Looks like you did this manually (missing spaces around*). > >>> Why not feed this to uncrustify instead? > >>> > >> > >> Did function by function, help on getting that even cleaner welcome as > >> usual. > > > > Maybe the uncrustify file we usually use could be added to the tree > > under doc/ or tools/ > > given uncrustify shortcomings it can't be used on a large file, would be > nice if somebody volunteers to prepare a style for clang-format (if it > works better)
I've used it successfully on some of the largest files in libav, e.g. h264.c, so I really don't know what you are talking about... Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
