On 22/10/13 13:19, Derek Buitenhuis wrote:
> On 10/22/2013 12:09 PM, Luca Barbato wrote:
>>> -            init_get_bits(&gb, s->avctx->extradata, 
>>> s->avctx->extradata_size*8);
>>> -            ret = ff_mpeg4_decode_picture_header(s, &gb);
>>> +            if (init_get_bits8(&gb, s->avctx->extradata, 
>>> s->avctx->extradata_size) >= 0 )
>>> +                ret = ff_mpeg4_decode_picture_header(s, &gb);
>>
>> This looks wrong.
> 
> Care to elaborate?

init_get_bits8 fails

ret stays 0

> You perhaps prefer an explicit error path?

Might be a good idea.

lu



_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to