On Tue, 22 Oct 2013, Luca Barbato wrote:
On 22/10/13 15:16, Martin Storsjö wrote:
On Tue, 22 Oct 2013, Luca Barbato wrote:
On 09/10/13 14:03, Martin Storsjö wrote:
+ else if (track->enc->codec_id == AV_CODEC_ID_VP6F ||
+ track->enc->codec_id == AV_CODEC_ID_VP6A) {
+ /* Don't write any potential extradata here - the cropping
+ * is signalled via the normal width/height fields. */
+ } else if (track->vos_len > 0)
mov_write_glbl_tag(pb, track);
Not sure if having the condition merged below is nicer, beside that
doesn't look wrong.
No you can't move it below the existing one, since track->vos_len > 0
can be true for VP6 as well, but we intentionally should not write it to
the file. The track->vos_len > 0 case is a catch-all case for writing
"generic" extradata for codecs that don't need any special handling.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
I meant if (track->vos_tag > 0 && codec_id != AV_CODEC_ID_VP6F)
as said not sure which is the nicer.
Ah, I see. I think I prefer the current one though, which is clearer if
there's many different similar cases (although not sure if there will be
many others).
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
