On Fri, 25 Oct 2013 18:46:53 -0400, Justin Ruggles <[email protected]> wrote: > From: Michael Niedermayer <[email protected]> > > Fixes decoding regression >
The commit message is still quite vague. It could at least mention that the problem is with downmixing. > Signed-off-by: Michael Niedermayer <[email protected]> > Signed-off-by: Justin Ruggles <[email protected]> > > CC:[email protected] > --- > libavcodec/ac3dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > index fd0bf33..0957e14 100644 > --- a/libavcodec/ac3dec.c > +++ b/libavcodec/ac3dec.c > @@ -1398,7 +1398,7 @@ static int ac3_decode_frame(AVCodecContext * avctx, > void *data, > memcpy(s->outptr[channel_map[ch]], output[ch], > sizeof(**output) * AC3_BLOCK_SIZE); > for (ch = 0; ch < s->out_channels; ch++) > output[ch] = s->outptr[channel_map[ch]]; > - for (ch = 0; ch < s->channels; ch++) > + for (ch = 0; ch < s->out_channels; ch++) The patch itself looks good. Interesting that FATE does test 5.1 dowmnmixing, but didn't catch this. Any idea why? -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
