On Mon,  4 Nov 2013 21:24:11 +0100, Diego Biurrun <[email protected]> wrote:
> ---
>  libavcodec/mpegaudioenc.c |   14 ++++++++++++++
>  libavcodec/mpegaudiotab.h |   14 --------------
>  2 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/libavcodec/mpegaudioenc.c b/libavcodec/mpegaudioenc.c
> index 739eb64..7e0fda5 100644
> --- a/libavcodec/mpegaudioenc.c
> +++ b/libavcodec/mpegaudioenc.c
> @@ -67,6 +67,20 @@ typedef struct MpegAudioContext {
>  #include "mpegaudiodata.h"
>  #include "mpegaudiotab.h"
>  

I'd move those to MpegAudioContext.

Potentially saving a couple bytes is not worth all the trouble with global
state.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to