On Thu, Nov 21, 2013 at 07:11:25PM -0800, Alex Converse wrote:
> On Sun, Nov 10, 2013 at 1:31 PM, Diego Biurrun <[email protected]> wrote:
> >
> > ---
> >
> > Now addresses most of Alex' comments and actually eliminates all warnings.
> >
> >  libavcodec/aacps.c          |   18 +++++++++++-------
> >  libavcodec/aacps_tablegen.c |    2 +-
> >  libavcodec/aacps_tablegen.h |    4 +++-
> >  libavcodec/aacpsdsp.h       |    2 +-
> >  4 files changed, 16 insertions(+), 10 deletions(-)
> >
> 
> Seems ok
> 
> > --- a/libavcodec/aacpsdsp.h
> > +++ b/libavcodec/aacpsdsp.h
> > @@ -38,7 +38,7 @@ typedef struct PSDSPContext {
> >                                     int i, int len);
> >      void (*decorrelate)(float (*out)[2], float (*delay)[2],
> >                          float 
> > (*ap_delay)[PS_QMF_TIME_SLOTS+PS_MAX_AP_DELAY][2],
> > -                        const float phi_fract[2], float (*Q_fract)[2],
> > +                        const float phi_fract[2], const float 
> > (*Q_fract)[2],
> >                          const float *transient_gain,
> >                          float g_decay_slope,
> >                          int len);
> 
> FWIW this part no longer matches the implementations

I updated aacpsdsp.c to match and pushed.

Thanks for the reviews.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to