On Thu, Nov 21, 2013 at 10:44:31AM +0000, Derek Buitenhuis wrote:
> This allows MSVC 2013 and ICL to build with no external
> dependencies.
>
> Signed-off-by: Derek Buitenhuis <[email protected]>
> ---
> The script itself should be entirely portable between any POSIX
> system.
>
> I am unsure that compat/ was the correct place to put htis script.
> Comments welcome.
> ---
> compat/makedef | 130
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> configure | 2 +-
> 2 files changed, 131 insertions(+), 1 deletion(-)
> create mode 100755 compat/makedef
Just some quick comments, I need to think this through a bit.
I'll also try to read it through in more detail later.
> --- /dev/null
> +++ b/compat/makedef
> @@ -0,0 +1,130 @@
> +#!/bin/sh
> +
> +# mktemp isn't POSIX, so supply an implementation
> +mktemp() {
> + echo "${2%%XXX*}.${HOSTNAME}.${UID}.$$"
> +}
I'm scared shitless every time I see such hacks intended to replace
security tools.
> +if [ $# -lt 2 ]; then
> + echo "Usage: makedef <version_script> <objects>" >&2
This redirection is a bashism.
Have you tried running this script in dash or so?
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
