On 11/24/2013 09:44 PM, Diego Biurrun wrote:
> On Sun, Nov 24, 2013 at 09:49:47AM -0800, John Stebbins wrote:
>> @@ -2057,6 +2118,8 @@ static void mpeg_decode_user_data(AVCodecContext
>> *avctx,
>> return;
>> avctx->dtg_active_format = p[0] & 0x0f;
>> }
>> + } else if (mpeg_decode_cc(avctx, p, buf_size)) {
>> + return;
>> }
> You return different values above, but no error checking whatsoever is
> performed here. What was your intention?
>
>
I might not have completely understood you meaning the first time I read this.
The intention here is to return early if
mpeg_decode_cc detected that this user data is cc data and processed it.
There's no point in continuing to look for
other types of user data. It's really kind of pointless at present since it is
the last thing in the function
currently. But it sets the pattern to follow if anyone adds more user data
parsing after it. It can be dropped and we
can just rely on the next person that adds more user data parsing to do this
right if you wish.-- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
signature.asc
Description: OpenPGP digital signature
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
