On 02/12/13 03:57, Diego Biurrun wrote: > On Sun, Dec 01, 2013 at 04:34:45AM +0100, Luca Barbato wrote: >> And use it to check for pthreads support. >> >> Unbreak f058f384a0d76bfd125f4738dceab7c890186432 for *BSD since their >> compilers have a false positive with pthread_join. >> --- >> configure | 31 ++++++++++++++++++++++++------- >> 1 file changed, 24 insertions(+), 7 deletions(-) > > Feels very hackish to me. I'm confident there is a better solution > to the root problem that this is working around.
As stated (even in the comment in configure) the pthreads tests is brittle and requires to have the least amount of libs around when it is done (thus moving down zlib and bz2 checks). A "correct way" to do that is to extend my patch to cover ALL the symbols we use. On BSD they have this _strange_ separation between libc and libthr causing the problem with this specific pick of symbols. Another possible solution would be changing the order and do - check for -pthread - check for -pthreads - check for nothing-at-all - check for -lpthread Assuming the compiler would fail to parse the option if it is not supported. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
