On Wed, Dec 04, 2013 at 01:31:32AM +0000, Timothy Gu wrote:
> Diego Biurrun <diego@...> writes:
> 
> > -elif check_header _mingw.h; then
> > -    libc_type=mingw
> > -    check_cpp_condition _mingw.h \
> > -        "defined (__MINGW64_VERSION_MAJOR) || (__MINGW32_MAJOR_VERSION > 
> > 3) 
> || \
> 
> > +elif check_cpp_condition _mingw.h "defined __MINGW64_VERSION"; then
> 
> Why don't you check __MINGW64_VERSION_MAJOR?

I could indeed, see the updated patch.

> > +    libc_type=mingw64
> > +    add_cppflags -U__STRICT_ANSI__
> 
> > +elif check_cpp_condition _mingw.h "defined __MINGW32_VERSION"; then
> 
> These 2 macros are never defined (__MINGW*_VERSION). See
> http://sourceforge.net/p/predef/wiki/Compilers/#mingw-and-mingw-w64

My _mingw.h header disagrees with that statement of yours; it very
much #defines __MINGW32_VERSION.

> P.S. Gmane needs me prune quoted stuff so sorry if it causes any inconvenience

Everything is fine, don't worry.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to