On Tue, Dec 3, 2013 at 6:33 PM, Anton Khirnov <[email protected]> wrote:
>
> On Thu, 28 Nov 2013 15:02:58 +0100, Vittorio Giovara 
> <[email protected]> wrote:
>> ---
>>  Changelog            |    1 +
>>  doc/APIchanges       |    4 ++
>>  libavutil/Makefile   |    2 +
>>  libavutil/frame.h    |    4 ++
>>  libavutil/stereo3d.c |   53 ++++++++++++++++++
>>  libavutil/stereo3d.h |  152 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  libavutil/version.h  |    2 +-
>>  7 files changed, 217 insertions(+), 1 deletion(-)
>>  create mode 100644 libavutil/stereo3d.c
>>  create mode 100644 libavutil/stereo3d.h
>>
>> diff --git a/Changelog b/Changelog
>> index 9747720..78b3338 100644
>> --- a/Changelog
>> +++ b/Changelog
>> @@ -50,6 +50,7 @@ version 10:
>>  - VP9 decoder
>>  - support for decoding through VDPAU in avconv (the -hwaccel option)
>>  - remove mp3_header_(de)compress bitstream filters
>> +- codec level stereoscopic metadata handling
>
> "codec level"?

I needed a way to distinguish it from the container level metadata...
Does "- stereoscopic 3d metadata handling within bitstream" sound
better?

>> +}
>> +
>> +void av_stereo3d_free(AVStereo3D **data)
>
> I wonder how much point is there in a dedicated destructor, if we want to use
> this as side data, since that doesn't allow the side data to have further
> substructure.

Well theoretically this struct could be reused for container metadata too.
Shall I remove it and add it again when necessary or may I just leave it in?
Also the allocator is not used anywhere right now, but I guess that
it's needed for abi.

All other changes amended locally, thank you.
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to