On 12/08/2013 05:59 PM, Pascal Massimino wrote:
+end:
>+    free(mw.mem); /* must use free() according to libwebp documentation */
>+    if (pic_is_copy)
>
actually, you don't need 'pic_is_copy' at all. You can just call
WebPPictureFree() always, in all cases, and it will take care of
free the memory.

Otherwise, looks good. Thanks for doing this!


>+        WebPPictureFree(pic);
>+    av_freep(&pic);
>+    if (alt_frame)
>+        av_frame_free(&alt_frame);
>+
>+    return ret;
>+}
>+

Ok. It wasn't very clear from the documentation what the WebPPicture functions actually do. Looking at the libwebp source, I can see that it won't mess with the manually set data pointers, so I'll change it as you suggested.

Thanks,
Justin

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to