On 12/12/13 12:53, Diego Biurrun wrote:
> On Wed, Dec 11, 2013 at 02:39:37PM +0100, Luca Barbato wrote:
>> --- a/configure
>> +++ b/configure
>> @@ -3833,9 +3833,6 @@ check_header VideoDecodeAcceleration/VDADecoder.h
>>  
>> -disabled  zlib || check_lib   zlib.h      zlibVersion -lz   || disable  zlib
>> -disabled bzlib || check_lib2 bzlib.h BZ2_bzlibVersion -lbz2 || disable bzlib
>> -
>>  if ! disabled w32threads && ! enabled pthreads; then
>>      check_func_headers "windows.h process.h" _beginthreadex && enable 
>> w32threads
>>  fi
>> @@ -3859,6 +3856,9 @@ if ! disabled pthreads && ! enabled w32threads; then
>>      fi
>>  fi
>>  
>> +disabled  zlib || check_lib   zlib.h      zlibVersion -lz   || disable  zlib
>> +disabled bzlib || check_lib2 bzlib.h BZ2_bzlibVersion -lbz2 || disable bzlib
>> +
>>  for thread in $THREADS_LIST; do
>>      if enabled $thread; then
>>          test -n "$thread_type" &&
> 
> This moves the *zlib checks into the middle of the pthreads check.  Is
> there a reason for this?  Otherwise move it after all the threads checks.

Not really, anything below that block would work just fine =)

> A comment explaining why it is where it is would also avoid this getting
> moved around again in the future.

Sure.

lu


_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to