On Fri, Dec 20, 2013 at 01:00:22PM +0100, Anton Khirnov wrote:
> --- a/libavcodec/x86/mpegvideoenc.c
> +++ b/libavcodec/x86/mpegvideoenc.c
> @@ -82,6 +82,118 @@ DECLARE_ALIGNED(16, static uint16_t,
> inv_zigzag_direct16)[64];
>
> +#if HAVE_INLINE_ASM
> +static void denoise_dct_mmx(MpegEncContext *s, int16_t *block){
> +}
> +
> +static void denoise_dct_sse2(MpegEncContext *s, int16_t *block){
> + );
> +}
> +#endif /* HAVE_INLINE_ASM */
> +
> av_cold void ff_MPV_encode_init_x86(MpegEncContext *s)
> {
I'm slightly suspicous that this is under different ifdefs than the
assignments below.
> @@ -93,16 +205,20 @@ av_cold void ff_MPV_encode_init_x86(MpegEncContext *s)
> if (dct_algo == FF_DCT_AUTO || dct_algo == FF_DCT_MMX) {
> #if HAVE_MMX_INLINE
> int cpu_flags = av_get_cpu_flags();
> - if (INLINE_MMX(cpu_flags))
> + if (INLINE_MMX(cpu_flags)) {
> s->dct_quantize = dct_quantize_MMX;
> + s->denoise_dct = denoise_dct_mmx;
> + }
align
> #if HAVE_SSE2_INLINE
> - if (INLINE_SSE2(cpu_flags))
> + if (INLINE_SSE2(cpu_flags)) {
> s->dct_quantize = dct_quantize_SSE2;
> + s->denoise_dct = denoise_dct_sse2;
> + }
align
Looks mostly good to me. I'll run this through my test scripts and push
if it passes. Unqueue on your side, I got this.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
