On Mon, Jan 6, 2014 at 7:08 PM, Diego Biurrun <[email protected]> wrote: > On Mon, Jan 06, 2014 at 05:14:42PM +0100, Vittorio Giovara wrote: >> --- a/libavfilter/avfilter.c >> +++ b/libavfilter/avfilter.c >> @@ -748,13 +749,18 @@ int ff_filter_frame(AVFilterLink *link, AVFrame *frame) >> case AVMEDIA_TYPE_AUDIO: >> out = ff_get_audio_buffer(link, frame->nb_samples); >> break; >> - default: return AVERROR(EINVAL); >> + default: >> + ret = AVERROR(EINVAL); >> + goto fail; > > I'd do the cosmetics separately, for the whole file. > I don't understand why you want to free 'out' here, it has > not been allocated yet...
frame also needs to be deallocated, it seemed "cleaner" to have all clean up at the end of the function. Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
