On Wed, 8 Jan 2014 03:25:42 +0100, Luca Barbato <[email protected]> wrote: > From: Matthieu Bouron <[email protected]> > > Signed-off-by: Luca Barbato <[email protected]> > --- > libavformat/mxfdec.c | 115 > +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 115 insertions(+) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index c1cf8ec..8c0c018 100644 > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c > @@ -1618,6 +1618,120 @@ fail_and_free: > return ret; > } >
The patch looks generally fine, except for those two nits: - size is only checked for strings; no idea if this can break anything, likely not - perhaps it'd be better to strdup the strings converted from utf16, as the buffer is allocated for the maximum possible size, but will in most cases be much smaller -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
