On 2014-01-08 03:25:50 +0100, Luca Barbato wrote:
> From: Michael Niedermayer <[email protected]>
> 
> Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
> Signed-off-by: Luca Barbato <[email protected]>
> ---
>  libavformat/mxfdec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index 14ac5cb..9e916bc 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -2047,6 +2047,9 @@ static int mxf_read_close(AVFormatContext *s)
>  
>      for (i = 0; i < mxf->metadata_sets_count; i++) {
>          switch (mxf->metadata_sets[i]->type) {
> +        case Descriptor:
> +            av_freep(&((MXFDescriptor *)mxf->metadata_sets[i])->extradata);
> +            break;
>          case MultipleDescriptor:
>              av_freep(&((MXFDescriptor 
> *)mxf->metadata_sets[i])->sub_descriptors_refs);
>              break;

I fail to see how this is supposed to prevent a double free. It looks
more like fixing a memory leak.

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to