On 01/14/2014 08:18 PM, Tim Walker wrote:
When mixing 3 front channels into 2, the center channel is mixed into left and right with the center mix level, not -3dB. --- libavresample/audio_mix_matrix.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)diff --git a/libavresample/audio_mix_matrix.c b/libavresample/audio_mix_matrix.c index 8da1b48..487869b 100644 --- a/libavresample/audio_mix_matrix.c +++ b/libavresample/audio_mix_matrix.c @@ -126,8 +126,13 @@ int avresample_build_matrix(uint64_t in_layout, uint64_t out_layout, /* mix front center to front left/right */ if (unaccounted & AV_CH_FRONT_CENTER) { if ((out_layout & AV_CH_LAYOUT_STEREO) == AV_CH_LAYOUT_STEREO) { - matrix[FRONT_LEFT ][FRONT_CENTER] += M_SQRT1_2; - matrix[FRONT_RIGHT][FRONT_CENTER] += M_SQRT1_2; + if ((in_layout & AV_CH_LAYOUT_STEREO) == AV_CH_LAYOUT_STEREO) { + matrix[FRONT_LEFT ][FRONT_CENTER] += center_mix_level; + matrix[FRONT_RIGHT][FRONT_CENTER] += center_mix_level; + } else { + matrix[FRONT_LEFT ][FRONT_CENTER] += M_SQRT1_2; + matrix[FRONT_RIGHT][FRONT_CENTER] += M_SQRT1_2; + } } else return AVERROR_PATCHWELCOME; }
LGTM -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
