On Tue, 21 Jan 2014, Janne Grunau wrote:

On 2014-01-21 09:35:19 +0200, Martin Storsjö wrote:
On Mon, 20 Jan 2014, Janne Grunau wrote:

Handles fft4_neon and fft65536_neon from libavcodec/arm/fft_neon.S
correctly which are only called through pc-relative offsets. Fixes
i?mdct-4 fate tests on iOS with thumb.

Signed-off-by: Janne Grunau <[email protected]>
---
gas-preprocessor.pl | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 2072ca3..cdfb95d 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -483,6 +483,12 @@ foreach my $line (@pass1_lines) {
        }
    }

+    if ($thumb and $line =~ /^\s*\.word\s+(\w+)\s*$/) {
+        if (exists $thumb_labels{$1}) {
+            print ASMFILE ".thumb_func $1\n";
+        }
+    }
+
    # @l -> lo16()  @ha -> ha16()
    $line =~ s/,\s+([^,]+)\@l\b/, lo16($1)/g;
    $line =~ s/,\s+([^,]+)\@ha\b/, ha16($1)/g;
--
1.8.5.3

Ok

Doesn't work unfortunately, forgot --enable-pic in test build

Breaks in vp8_armv6.S due to a '.thumb_func 0'. I'm thinking of
replacing the .func directive with .thumb_func instead of commenting it
out. That makes at least sure that all functions are locally declared as
.thumb_func

Right - that does sound like it would make sense, and is probably more straightforward than trying to parse everything that's passed to .word to identify possible function symbols.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to