On Thu, Jan 23, 2014 at 10:53 AM, Diego Biurrun <[email protected]> wrote: > On Wed, Jan 22, 2014 at 09:32:22PM +0100, Vittorio Giovara wrote: >> > #include "url.h" >> > -#include <stdarg.h> >> > #if CONFIG_NETWORK >> > #include "network.h" >> > #endif >> >> I think you should add a new line between header groups. > > Is that the agreed-upon standard now?
Yup, see https://wiki.libav.org/CodingStyle/HeaderOrdering > >> > @@ -402,7 +415,7 @@ int avformat_open_input(AVFormatContext **ps, const >> > char *filename, AVInputForma >> > if (s->iformat->priv_class) { >> > - *(const AVClass**)s->priv_data = s->iformat->priv_class; >> > + *(const AVClass **) s->priv_data = s->iformat->priv_class; >> >> Extra space after ) > > That's the way that THE BOOK formats most of its casts. > >> > @@ -738,49 +757,58 @@ static void compute_pkt_fields(AVFormatContext *s, >> > AVStream *st, >> > >> > - // some mpeg2 in mpeg-ps lack dts (issue171 / input_file.mpg) >> > - // we take the conservative approach and discard both >> > - // Note, if this is misbehaving for a H.264 file then possibly >> > presentation_delayed is not set correctly. >> > - if(delay==1 && pkt->dts == pkt->pts && pkt->dts != AV_NOPTS_VALUE && >> > presentation_delayed){ >> > + /* Some MPEG-2 in MPEG-PS lack dts (issue171 / input_file.mpg). We >> > take the >> >> Maybe "issue #171"? >> Also DTS. > > I would lowercase decode timestamp and presentation timestamp, but > uppercase Digital Theater Systems. Well it's hard to mix the two acronyms because of the context in which they are used, but in either case it's DTS almost everywhere in this file. Feel free to push it anyway. Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
