On 02/02/2014 02:13 PM, Hendrik Leppkes wrote: > On Sun, Feb 2, 2014 at 11:06 PM, Tim Walker <[email protected]> wrote: >> On 02 Feb 2014, at 17:39, John Stebbins <[email protected]> wrote: >> >>> --- >>> libavcodec/aacdec.c | 11 +++++++---- >>> 1 file changed, 7 insertions(+), 4 deletions(-) >> Did I really miss this? I was sure I had tested some AAC sources when >> switching to those AVFrame fields. > There should be fallback code inplace to initialize the AVFrame values > to the ones from the avctx, so unless it actually changed within this > audio frame, it probably didn't make a functional difference. > Still better to set it explicitly here, i guess. > >
This does make a functional difference. I looked for the fallback code you mention. It looks like it is in ff_get_buffer()? In aacdec, ff_get_buffer is called before avctx->sample_rate has been set for the first time. So the first frame returned does not has an AVFrame.sample_rate == 0. -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
signature.asc
Description: OpenPGP digital signature
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
