On Tue, Feb 04, 2014 at 03:40:32PM -0500, Justin Ruggles wrote:
> I've encountered quite a few samples using these fourcc values. The
> only reference I could find to them is in the CoreMedia API docs.

Rephrase this from a neutral perspective.

> --- a/libavformat/isom.c
> +++ b/libavformat/isom.c
> @@ -156,6 +156,7 @@ const AVCodecTag ff_codec_movvideo_tags[] = {
>      { AV_CODEC_ID_MPEG1VIDEO, MKTAG('m', '1', 'v', '1') }, /* Apple MPEG-1 
> Camcorder */
>      { AV_CODEC_ID_MPEG1VIDEO, MKTAG('m', 'p', 'e', 'g') }, /* MPEG */
> +    { AV_CODEC_ID_MPEG1VIDEO, MKTAG('m', 'p', '1', 'v') }, /* From CoreMedia 
> CMVideoCodecType */
>      { AV_CODEC_ID_MPEG2VIDEO, MKTAG('m', '2', 'v', '1') }, /* Apple MPEG-2 
> Camcorder */

Drop the "from".

> @@ -200,6 +201,7 @@ const AVCodecTag ff_codec_movvideo_tags[] = {
>      { AV_CODEC_ID_MPEG2VIDEO, MKTAG('A', 'V', 'm', 'p') }, /* AVID IMX PAL */
> +    { AV_CODEC_ID_MPEG2VIDEO, MKTAG('m', 'p', '2', 'v') }, /* From CoreMedia 
> CMVideoCodecType */

same

LGTM otherwise.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to