On 2014-02-07 17:01:06 +0200, Martin Storsjö wrote:
>
> >> + if ($cond ne "ic") {
> >> + if (exists $thumb_labels{$label}) {
> >> + print ASMFILE ".thumb_func $label\n";
> >> + } else {
> >> + $call_targets{$label}++;
> >> + }
> >> }
> >> }
> >
> >ok,
> >
> >doing it this way is probably best for clarity
>
> I now later came to think that I could probably stuff it into the RE
> as well, having the (..) match anything but ic, saving one indentation
> level here. But do you still prefer the explicit check here over
> extending the RE?
I don't care much, I think this is a little more explicit but my first
impulse was suggesting to stuff it into the RE. Do as you prefer
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
