On Fri, 7 Feb 2014, Janne Grunau wrote:
On 2014-02-07 20:40:43 +0200, Martin Storsjö wrote:
On Fri, 7 Feb 2014, Janne Grunau wrote:
---
configure | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/configure b/configure
index 7a305c3..abee247 100755
--- a/configure
+++ b/configure
@@ -4208,6 +4208,18 @@ elif enabled_any msvc icl; then
fi
fi
+case $ld_type in
+ clang)
+ check_ldflags -Qunused-arguments
+ ;;
+esac
This silences the warnings about -pthread, right? I would kinda
prefer to have the code that tries to add that option changed to
Luca's second (original) alternative since that felt more robust to
me. OTOH I guess there's not much value in intentionally annoying us
with this warning until that is done either.
Yes, it silence the -pthread warning and yes we should try to avoid
adding it when it's not needed. Mostly added it here for consistency
with CFLAGS and ASFLAGS, I won't object dropping it
Nah, it's probably good in general to have it around, we'll have to try to
fix the -pthreads stuff anyway.
+
+case $as_type in
+ clang)
+ add_asflags -Qunused-arguments
+ ;;
+esac
+
This is more important since clang warns about every arguments when
using gas-preprocessor.
Indeed. Patch ok to push.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
