On Sat, Feb 8, 2014 at 10:53 PM, Luca Barbato <[email protected]> wrote:

> On 09/02/14 02:59, Andrew Kelley wrote:
> > +    av_assert2(channels > 0); /* would corrupt delay_count and
> delay_index */
>
> Reachable asserts are BUGS and SECURITY ISSUES.
>

This is not reachable in release code. From av_assert.h:

#if defined(ASSERT_LEVEL) && ASSERT_LEVEL > 1
#define av_assert2(cond) av_assert0(cond)
#else
#define av_assert2(cond) ((void)0)
#endif


Or perhaps I do not understand your meaning?

The rest of the code might or might not look like something avresample
> would do.
>

I'm sorry, again I don't understand what you are implying. Are you saying
the rest of the code looks relatively OK?
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to