On Sat, Feb 08, 2014 at 05:04:04PM -0500, Justin Ruggles wrote:
> --- a/libavcodec/tiff.c
> +++ b/libavcodec/tiff.c
> @@ -447,20 +447,31 @@ static int tiff_decode_tag(TiffContext *s)
> + avpriv_report_missing_feature(s->avctx,
> + "Unimplemented
> PhotometricInterpretation: "
> + "0x%04X", value);
Unimplemented PhotometricInterpretation: 0x3 is not implemented
sounds odd, drop the "unimplemented and the colon.
> --- a/libavcodec/tiff.h
> +++ b/libavcodec/tiff.h
> @@ -82,6 +82,24 @@ enum TiffTypes {
> TIFF_RATIONAL,
> };
>
> +enum TiffPhotometric {
> + TIFF_PHOTOMETRIC_NONE = -1,
> + TIFF_PHOTOMETRIC_WHITEISZERO, /* mono or grayscale, 0 is white */
> + TIFF_PHOTOMETRIC_BLACKISZERO, /* mono or grayscale, 0 is black */
_IS_ZERO would be more readable IMO.
> + TIFF_PHOTOMETRIC_RGB, /* RGB or RGBA*/
> + TIFF_PHOTOMETRIC_PALETTE, /* Uses a palette */
> + TIFF_PHOTOMETRIC_ALPHA_MASK, /* Transparency mask */
> + TIFF_PHOTOMETRIC_SEPARATED, /* CMYK or some other ink set */
> + TIFF_PHOTOMETRIC_YCBCR, /* YCbCr */
> + TIFF_PHOTOMETRIC_CIELAB = 8, /* 1976 CIE L*a*b* */
> + TIFF_PHOTOMETRIC_ICCLAB, /* ICC L*a*b* */
> + TIFF_PHOTOMETRIC_ITULAB, /* ITU L*a*b* */
> + TIFF_PHOTOMETRIC_CFA = 32803, /* Color Filter Array (DNG) */
> + TIFF_PHOTOMETRIC_LOGL = 32844, /* CIE Log2(L) */
> + TIFF_PHOTOMETRIC_LOGLUV,
> + TIFF_PHOTOMETRIC_LINEARRAW = 34892, /* Linear Raw (DNG) */
Same in some of these other values, some use underscores some don't.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
