On 2014-02-10 12:17:30 +0100, Diego Biurrun wrote:
> On Sun, Feb 09, 2014 at 07:28:17PM +0100, Luca Barbato wrote:
> > From: Peter B <[email protected]>
> > 
> > Signed-off-by: Luca Barbato <[email protected]>
> > ---
> > +###################################################
> > +#  Decoding:
> > +###################################################
> > +#  YUV (8bit)
> > +fate-ffv1-dec-v1-defaults:       ${CMD = framecrc -i 
> > $(DEC_SRC)/ffv1-enc-v1-defaults.avi} fate-ffv1-enc-v1-defaults
> > +fate-ffv1-dec-v1-yuv410p:        ${CMD = framecrc -i 
> > $(DEC_SRC)/ffv1-enc-v1-yuv410p.avi} fate-ffv1-enc-v1-yuv410p
> > +fate-ffv1-dec-v1-yuv411p:        ${CMD = framecrc -i 
> > $(DEC_SRC)/ffv1-enc-v1-yuv411p.avi} fate-ffv1-enc-v1-yuv411p
> > +fate-ffv1-dec-v1-yuv420p:        ${CMD = framecrc -i 
> > $(DEC_SRC)/ffv1-enc-v1-yuv420p.avi} fate-ffv1-enc-v1-yuv420p
> > +fate-ffv1-dec-v1-yuv422p:        ${CMD = framecrc -i 
> > $(DEC_SRC)/ffv1-enc-v1-yuv422p.avi} fate-ffv1-enc-v1-yuv422p
> > +fate-ffv1-dec-v1-yuv444p:        ${CMD = framecrc -i 
> > $(DEC_SRC)/ffv1-enc-v1-yuv444p.avi} fate-ffv1-enc-v1-yuv444p
> > +fate-ffv1-dec-v1-yuv440p:        ${CMD = framecrc -i 
> > $(DEC_SRC)/ffv1-enc-v1-yuv440p.avi} fate-ffv1-enc-v1-yuv440p
> 
> Generally $() is preferred over ${}.

cleaner and more in sync with the rest to add
'fate-ffv1-dec-v1-%: fate-ffv1-enc-v1-%'
and drop the ${}

> > +# Requires generating vsynth1.yuv as input source:
> > +$(FATE_FFV1-yes): tests/data/vsynth1.yuv

missing $(TARGET_PATH)

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to