On Thu, Feb 13, 2014 at 12:47:27AM +0100, Vittorio Giovara wrote:
> Also uniform error style and drop redudant information.
"to uniform" as a verb only means to put into a uniform (clothing), so
I suggest "make consistent" here.
redu_n_dant
> --- a/libavcodec/h264.c
> +++ b/libavcodec/h264.c
> @@ -3814,7 +3813,7 @@ static int decode_slice_header(H264Context *h,
> H264Context *h0)
> tmp = get_ue_golomb_31(&h->gb);
> if (tmp > 2) {
> - av_log(h->avctx, AV_LOG_ERROR, "cabac_init_idc overflow\n");
> + av_log(h->avctx, AV_LOG_ERROR, "cabac_init_idc %d overflow\n",
> tmp);
tmp is unsigned.
> --- a/libavcodec/h264_ps.c
> +++ b/libavcodec/h264_ps.c
> @@ -311,7 +311,7 @@ int ff_h264_decode_seq_parameter_set(H264Context *h)
> if (sps_id >= MAX_SPS_COUNT) {
> - av_log(h->avctx, AV_LOG_ERROR, "sps_id (%d) out of range\n", sps_id);
> + av_log(h->avctx, AV_LOG_ERROR, "sps_id %u out of range\n", sps_id);
> return AVERROR_INVALIDDATA;
> }
> @@ -529,7 +529,7 @@ int ff_h264_decode_picture_parameter_set(H264Context *h,
> int bit_length)
> if (pps_id >= MAX_PPS_COUNT) {
> - av_log(h->avctx, AV_LOG_ERROR, "pps_id (%d) out of range\n", pps_id);
> + av_log(h->avctx, AV_LOG_ERROR, "pps_id %u out of range\n", pps_id);
> return AVERROR_INVALIDDATA;
> @@ -544,7 +544,7 @@ int ff_h264_decode_picture_parameter_set(H264Context *h,
> int bit_length)
> if ((unsigned)pps->sps_id >= MAX_SPS_COUNT ||
> h->sps_buffers[pps->sps_id] == NULL) {
> - av_log(h->avctx, AV_LOG_ERROR, "sps_id out of range\n");
> + av_log(h->avctx, AV_LOG_ERROR, "sps_id %d out of range\n",
> pps->sps_id);
sps_id is unsigned.
overall nit: A couple of the lines you change are quite long.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
