On Sat, Feb 15, 2014 at 06:40:57PM +0100, Vittorio Giovara wrote:
> --- a/libavfilter/vf_interlace.c
> +++ b/libavfilter/vf_interlace.c
> @@ -44,7 +44,9 @@ enum FieldType {
> typedef struct {
> const AVClass *class;
> enum ScanMode scan; // top or bottom field first scanning
> +#if LIBAVFILTER_VERSION_MAJOR < 5
> int lowpass; // enable or disable low pass filterning
> +#endif
> AVFrame *cur, *next; // the two frames from which the new one is
> obtained
No, this is not how deprecation should be done. Instead, add a new
FF_API_FOO definition to libavfilter/version.h and test for that.
> @@ -58,8 +60,10 @@ static const AVOption options[] = {
> AV_OPT_TYPE_CONST, {.i64 = MODE_TFF }, INT_MIN, INT_MAX, .flags = V,
> .unit = "scan" },
> { "bff", "bottom field first", 0,
> AV_OPT_TYPE_CONST, {.i64 = MODE_BFF }, INT_MIN, INT_MAX, .flags = V,
> .unit = "scan" },
> - { "lowpass", "enable vertical low-pass filter", OFFSET(lowpass),
> +#if LIBAVFILTER_VERSION_MAJOR < 5
> + { "lowpass", "(deprecated, the filter is always set)", OFFSET(lowpass),
The filter cannot be set, do you mean option?
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
