On Tue, Feb 25, 2014 at 01:44:03PM +0100, Vittorio Giovara wrote:
> ---
> This was identified as one of the last remaining functions that interweaved
> lavc and lavf badly, so at our fosdem meeting it was suggested to move the
> common parts into lavu.
> 
> The results of a full oracle run (~25 hours) is available on oracle.libav.org

Do you have to move all three parts together?  This patch is really huge.

> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -13,6 +13,9 @@ libavutil:     2013-12-xx
>  
>  API changes, most recent first:
>  
> +2014-02-xx - xxxxxxx - lavu 53.5.1
> +  Move get_bits.h, put_bits.h and mathops.h from lavc to lavu.

Do we really have to make this one public?

> --- a/libavcodec/4xm.c
> +++ b/libavcodec/4xm.c
> @@ -30,7 +30,7 @@
>  #include "avcodec.h"
>  #include "bytestream.h"
>  #include "dsputil.h"
> -#include "get_bits.h"
> +#include "libavutil/get_bits.h"
>  #include "internal.h"

You probably did the change with sed, but it would be nice if you could
move the #include to the proper place while you're at it.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to